-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix contextmenu wrapping and submenu displaying bugs #732
Conversation
@yhy0217 found a small bug, when I open the layer context menu, the map contextmenu opens also: Also, noticed this when opening the context menu for the layer near the margin, if its a simple fix, are you able to replicate the same function for the layer contextmenu as you did for the map contextmenu: If that's not as simple, you can create a new issue and we can handle it in a separate PR. |
Finished to fix the bug that two menus open at the same time; however the layer menu does not wrap up on my laptop, and I think it should not happen because the new codes change the style of all buttons inside both two menus (as they all have same classname ".mapml-contextmenu-item"), but I may be wrong. Could you please run the code again and see if there is any change about the styling? |
Yes you are right, sorry for my misunderstanding. Have updated the code to fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Changing the magic numbers to variables would make the code more meaningful, which you have mostly done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM, please merge / rebase and merge when ready. |
Closes #684